Skip to content

fix: build on haiku by adding missing import#123354

Merged
bors merged 2 commits intorust-lang:masterfrom
SteveLauC:fix/haiku
Apr 2, 2024
Merged

fix: build on haiku by adding missing import#123354
bors merged 2 commits intorust-lang:masterfrom
SteveLauC:fix/haiku

Conversation

@SteveLauC
Copy link
Contributor

@SteveLauC SteveLauC commented Apr 2, 2024

Fix the build on Haiku by adding a missing import

error[E0433]: failed to resolve: use of undeclared crate or module `slice`
   --> /localhome/somers/.rustup/toolchains/nightly-x86_64-unknown-freebsd/lib/rustlib/src/rust/library/std/src/sys/pal/unix/thread.rs:272:24
    |
272 |             let name = slice::from_raw_parts(info.name.as_ptr() as *const u8, info.name.len());
    |                        ^^^^^ use of undeclared crate or module `slice`
    |
help: consider importing one of these items
    |
1   + use alloc::slice;
    |
1   + use core::slice;
    |
1   + use crate::slice;

Closes #123343

@rustbot
Copy link
Collaborator

rustbot commented Apr 2, 2024

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 2, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Noratrieb
Copy link
Member

Noratrieb commented Apr 2, 2024

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 2, 2024

📌 Commit bb43990 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2024
@SteveLauC
Copy link
Contributor Author

SteveLauC commented Apr 2, 2024

Hi @Nilstrieb, do I need to squash my commits?

@Noratrieb
Copy link
Member

Noratrieb commented Apr 2, 2024

you can if you want to and I can re-approve in that case, but I didn't want to bother you with it because I don't think it's that important here

@SteveLauC
Copy link
Contributor Author

SteveLauC commented Apr 2, 2024

but I didn't want to bother you with it because I don't think it's that important here

Ok, then I will leave them as-it

@bors
Copy link
Collaborator

bors commented Apr 2, 2024

⌛ Testing commit bb43990 with merge 36b6f9b...

@bors
Copy link
Collaborator

bors commented Apr 2, 2024

☀️ Test successful - checks-actions
Approved by: Nilstrieb
Pushing 36b6f9b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 2, 2024
@bors bors merged commit 36b6f9b into rust-lang:master Apr 2, 2024
@rustbot rustbot added this to the 1.79.0 milestone Apr 2, 2024
@rust-timer
Copy link
Collaborator

rust-timer commented Apr 2, 2024

Finished benchmarking commit (36b6f9b): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.1% [-3.1%, -3.1%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.4% [3.4%, 3.4%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.3% [-2.4%, -2.1%] 4
Improvements ✅
(secondary)		 -2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) -1.1% [-2.4%, 3.4%] 5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.7% [-1.7%, -1.7%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.7% [-1.7%, -1.7%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 667.636s -> 667.623s (-0.00%)
Artifact size: 315.59 MiB -> 315.65 MiB (0.02%)

@SteveLauC SteveLauC deleted the fix/haiku branch April 2, 2024 22:27
@workingjubilee workingjubilee added the O-haiku Target: Be extant; from mouldering old leaves; spring arrives again label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Amanieu Amanieu

Labels

merged-by-bors This PR was explicitly merged by bors. O-haiku Target: Be extant; from mouldering old leaves; spring arrives again O-unix Operating system: Unix-like S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.79.0

Development

Successfully merging this pull request may close these issues.

"use of undeclared crate or module slice" on x86_64-unknown-haiku

8 participants

@SteveLauC @rustbot @rust-log-analyzer @Noratrieb @bors @rust-timer @Amanieu @workingjubilee