Skip to content

Rollup of 2 pull requests#123346

Merged
bors merged 4 commits intorust-lang:masterfrom
workingjubilee:rollup-ix9qpsi
Apr 2, 2024
Merged

Rollup of 2 pull requests#123346
bors merged 4 commits intorust-lang:masterfrom
workingjubilee:rollup-ix9qpsi

Conversation

@workingjubilee
Copy link
Member

@workingjubilee workingjubilee commented Apr 2, 2024

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

jfgoog and others added 4 commits April 1, 2024 20:24
@jfgoog
Pass RUST_BACKTRACE when running docker.
652f6f7
@devnexen
std::thread: set_name change for solaris/illumos.
ca36fe3 
truncate down to 32 (31 + 1) for solaris/illumos.
@workingjubilee
Rollup merge of rust-lang#123323 - devnexen:thread_set_name_solaris_f…
48b2a51 
…ix, r=workingjubilee

std::thread: set_name change for solaris/illumos.

truncate down to 32 (31 + 1) for solaris/illumos.
@workingjubilee
Rollup merge of rust-lang#123330 - jfgoog:pass-backtrace, r=Kobzol
347c579 
Pass RUST_BACKTRACE when running docker.
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Apr 2, 2024
@workingjubilee
Copy link
Member Author

workingjubilee commented Apr 2, 2024

@bors rollup=never p=2

@workingjubilee
Copy link
Member Author

workingjubilee commented Apr 2, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 2, 2024

📌 Commit 347c579 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2024
@workingjubilee workingjubilee changed the title Rollup of 2 pull requests Rollup of 20240401 pull requests Apr 2, 2024
@workingjubilee
Copy link
Member Author

workingjubilee commented Apr 2, 2024

:^)

@workingjubilee workingjubilee changed the title Rollup of 20240401 pull requests Rollup of 2 pull requests Apr 2, 2024
@bors
Copy link
Collaborator

bors commented Apr 2, 2024

⌛ Testing commit 347c579 with merge 31075bb...

@bors
Copy link
Collaborator

bors commented Apr 2, 2024

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing 31075bb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 2, 2024
@bors bors merged commit 31075bb into rust-lang:master Apr 2, 2024
@rustbot rustbot added this to the 1.79.0 milestone Apr 2, 2024
@rust-timer
Copy link
Collaborator

rust-timer commented Apr 2, 2024

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#123323 std::thread: set_name change for solaris/illumos. e195cece26256e2be721eb4e98ca18f570e80e8e (link)
#123330 Pass RUST_BACKTRACE when running docker. 2e15c55c787d701f36dd2f8155b32e660e11a160 (link)

previous master: dd5e502d4b

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

rust-timer commented Apr 2, 2024

Finished benchmarking commit (31075bb): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.6% [2.6%, 2.6%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.5% [-1.5%, -1.5%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.5% [-1.5%, -1.5%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.168s -> 668.23s (-0.14%)
Artifact size: 315.68 MiB -> 315.68 MiB (-0.00%)

@workingjubilee workingjubilee deleted the rollup-ix9qpsi branch May 5, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. O-unix Operating system: Unix-like rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.79.0

Development

Successfully merging this pull request may close these issues.

6 participants

@workingjubilee @bors @rust-timer @rustbot @jfgoog @devnexen