Skip to content

Update LLVM submodule#122559

Merged
bors merged 1 commit intorust-lang:masterfrom
ForsakenHarmony:hrmny/update-llvm
Mar 16, 2024
Merged

Update LLVM submodule#122559
bors merged 1 commit intorust-lang:masterfrom
ForsakenHarmony:hrmny/update-llvm

Conversation

@ForsakenHarmony
Copy link
Contributor

@ForsakenHarmony ForsakenHarmony commented Mar 15, 2024 •
edited by nikic
Loading

LLVM version 18.1.1 + additional fixes.

Fixes Amanieu/corosensei#23.
Fixes #122252.
Fixes #121996.
Fixes #121960.

@rustbot
Copy link
Collaborator

rustbot commented Mar 15, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cuviper (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot
Copy link
Collaborator

rustbot commented Mar 15, 2024

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 15, 2024
This was referenced Mar 15, 2024
Closed
Merged
@nikic
Copy link
Contributor

nikic commented Mar 15, 2024

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Mar 15, 2024

📌 Commit f858f87 has been approved by nikic

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2024
@bors
Copy link
Collaborator

bors commented Mar 16, 2024

⌛ Testing commit f858f87 with merge 7aa1de7...

@bors
Copy link
Collaborator

bors commented Mar 16, 2024

☀️ Test successful - checks-actions
Approved by: nikic
Pushing 7aa1de7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 16, 2024
@bors bors merged commit 7aa1de7 into rust-lang:master Mar 16, 2024
@rustbot rustbot added this to the 1.78.0 milestone Mar 16, 2024
@rust-timer
Copy link
Collaborator

rust-timer commented Mar 16, 2024

Finished benchmarking commit (7aa1de7): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.6% [0.6%, 0.6%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.6% [0.6%, 0.6%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 670.527s -> 671.724s (0.18%)
Artifact size: 311.59 MiB -> 311.58 MiB (-0.00%)

@ForsakenHarmony ForsakenHarmony deleted the hrmny/update-llvm branch March 18, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cuviper cuviper

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.78.0

6 participants

@ForsakenHarmony @rustbot @nikic @bors @rust-timer @cuviper