Skip to content

docs: publish nightly doc for rustfix#118301

Merged
bors merged 3 commits intorust-lang:masterfrom
weihanglo:rustfix-doc
Dec 8, 2023
Merged

docs: publish nightly doc for rustfix#118301
bors merged 3 commits intorust-lang:masterfrom
weihanglo:rustfix-doc

Conversation

@weihanglo
Copy link
Member

@weihanglo weihanglo commented Nov 26, 2023

rustfix has migrated into rust-lang/cargo in rust-lang/cargo#13005. We now can publish nightly doc for it.

@rustbot
Copy link
Collaborator

rustbot commented Nov 26, 2023

r? @albertlarsan68

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Nov 26, 2023
albertlarsan68
albertlarsan68 reviewed Dec 7, 2023
View reviewed changes
Copy link
Member

@albertlarsan68 albertlarsan68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question

src/bootstrap/src/core/build_steps/doc.rs
Comment on lines -1006 to -1007
// FIXME: this trips a license check in tidy.
// "resolver-tests",
Copy link
Member

@albertlarsan68 albertlarsan68 Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

Copy link
Member Author

@weihanglo weihanglo Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more like an integration test not intended to have a public facing doc at this moment.

Thanks for the review :)

@albertlarsan68 albertlarsan68 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 7, 2023
@weihanglo
Copy link
Member Author

weihanglo commented Dec 7, 2023

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 7, 2023
@albertlarsan68
Copy link
Member

albertlarsan68 commented Dec 8, 2023

Thanks for the PR!
@bors r+

@bors
Copy link
Collaborator

bors commented Dec 8, 2023

📌 Commit 7232101 has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 8, 2023
@bors
Copy link
Collaborator

bors commented Dec 8, 2023

⌛ Testing commit 7232101 with merge 6c470a5...

@bors
Copy link
Collaborator

bors commented Dec 8, 2023

☀️ Test successful - checks-actions
Approved by: albertlarsan68
Pushing 6c470a5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 8, 2023
@bors bors merged commit 6c470a5 into rust-lang:master Dec 8, 2023
@rustbot rustbot added this to the 1.76.0 milestone Dec 8, 2023
@rust-timer
Copy link
Collaborator

rust-timer commented Dec 8, 2023

Finished benchmarking commit (6c470a5): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.6% [0.3%, 2.8%] 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.6% [0.3%, 2.8%] 2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.8% [0.6%, 0.9%] 2
Regressions ❌
(secondary)		 2.4% [2.2%, 2.7%] 2
Improvements ✅
(primary)		 -0.8% [-1.8%, -0.5%] 5
Improvements ✅
(secondary)		 -3.5% [-3.5%, -3.5%] 1
All ❌✅ (primary) -0.4% [-1.8%, 0.9%] 7

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.2% [0.4%, 2.8%] 3
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.2% [0.4%, 2.8%] 3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.716s -> 673.544s (-0.03%)
Artifact size: 314.08 MiB -> 314.03 MiB (-0.02%)

@rustbot rustbot added the perf-regression Performance regression. label Dec 8, 2023
@lqd
Copy link
Member

lqd commented Dec 8, 2023

Regressions are noise.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Dec 8, 2023
@weihanglo weihanglo deleted the rustfix-doc branch March 6, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albertlarsan68 albertlarsan68 albertlarsan68 left review comments

Assignees

@albertlarsan68 albertlarsan68

Labels

merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.76.0

Development

Successfully merging this pull request may close these issues.

6 participants

@weihanglo @rustbot @albertlarsan68 @bors @rust-timer @lqd