Skip to content

Remove some unnecessary(?) normalization#113348

Merged
bors merged 1 commit intorust-lang:masterfrom
saethlin:metadata-module-not-compiled
Jul 6, 2023
Merged

Remove some unnecessary(?) normalization#113348
bors merged 1 commit intorust-lang:masterfrom
saethlin:metadata-module-not-compiled

Conversation

@saethlin
Copy link
Member

@saethlin saethlin commented Jul 5, 2023

@rustbot
Copy link
Collaborator

rustbot commented Jul 5, 2023

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 5, 2023
@saethlin saethlin changed the title Remove some unnecessary normalization Remove some unnecessary(?) normalization Jul 5, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@saethlin saethlin force-pushed the metadata-module-not-compiled branch from a3d0a6c to 4e21e9e Compare July 5, 2023 23:52
@Noratrieb
Copy link
Member

Noratrieb commented Jul 6, 2023

r? Nilstrieb
@bors r+
let's see what happens

@bors
Copy link
Collaborator

bors commented Jul 6, 2023

📌 Commit 4e21e9e has been approved by Nilstrieb

It is now in the queue for this repository.

@rustbot rustbot assigned Noratrieb and unassigned davidtwco Jul 6, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2023
@bors
Copy link
Collaborator

bors commented Jul 6, 2023

⌛ Testing commit 4e21e9e with merge b112bc5...

@bors bors mentioned this pull request Jul 6, 2023
Merged
@bors
Copy link
Collaborator

bors commented Jul 6, 2023

☀️ Test successful - checks-actions
Approved by: Nilstrieb
Pushing b112bc5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 6, 2023
@bors bors merged commit b112bc5 into rust-lang:master Jul 6, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jul 6, 2023
@rust-timer
Copy link
Collaborator

rust-timer commented Jul 6, 2023

Finished benchmarking commit (b112bc5): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.8% [0.4%, 1.1%] 6
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.8% [0.4%, 1.1%] 6

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.9% [1.4%, 5.6%] 7
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 3.9% [1.4%, 5.6%] 7

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 656.666s -> 659.042s (0.36%)

@rustbot rustbot added the perf-regression Performance regression. label Jul 6, 2023
@Noratrieb
Copy link
Member

Noratrieb commented Jul 6, 2023

Only touches tests.

@Noratrieb Noratrieb added the perf-regression-triaged The performance regression has been triaged. label Jul 6, 2023
@saethlin saethlin deleted the metadata-module-not-compiled branch July 10, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Noratrieb Noratrieb

Labels

merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.72.0

Development

Successfully merging this pull request may close these issues.

7 participants

@saethlin @rustbot @rust-log-analyzer @Noratrieb @bors @rust-timer @davidtwco