Skip to content

Update cargo#110253

Merged
bors merged 1 commit intorust-lang:masterfrom
weihanglo:update-cargo
Apr 14, 2023
Merged

Update cargo#110253
bors merged 1 commit intorust-lang:masterfrom
weihanglo:update-cargo

Conversation

@weihanglo
Copy link
Member

@weihanglo weihanglo commented Apr 12, 2023 •
edited
Loading

4 commits in 7bf43f028ba5eb1f4d70d271c2546c38512c9875..84b7041fd2745ee6b3b4a150314f81aabb78e6b2
2023-04-10 16:01:41 +0000 to 2023-04-13 20:08:40 +0000

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 12, 2023

Some changes occurred in src/tools/cargo

cc @ehuss

@weihanglo
Copy link
Member Author

weihanglo commented Apr 12, 2023

r? @ehuss

rust-lang/cargo#11949 sneaked in. Do we want to make it into 1.70.0 as well?

@ehuss
Copy link
Contributor

ehuss commented Apr 13, 2023

Yea, I think that's fine to include. Can you also pull in rust-lang/cargo#11950 once it merges?

@weihanglo
Copy link
Member Author

weihanglo commented Apr 13, 2023

Updated. I'll merge this now.

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Apr 13, 2023

📌 Commit 544c5a5 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2023
@ehuss
Copy link
Contributor

ehuss commented Apr 13, 2023

Thanks!

@bors
Copy link
Collaborator

bors commented Apr 13, 2023

⌛ Testing commit 544c5a5 with merge 367661b...

@bors
Copy link
Collaborator

bors commented Apr 14, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 367661b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 14, 2023
@bors bors merged commit 367661b into rust-lang:master Apr 14, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 14, 2023
@bors bors mentioned this pull request Apr 14, 2023
Merged
@weihanglo weihanglo deleted the update-cargo branch April 14, 2023 05:19
@rust-timer
Copy link
Collaborator

rust-timer commented Apr 14, 2023

Finished benchmarking commit (367661b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.0% [-2.3%, -1.8%] 2
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.3% [-6.9%, -2.6%] 5
All ❌✅ (primary) - - 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ehuss ehuss

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.70.0

Development

Successfully merging this pull request may close these issues.

5 participants

@weihanglo @rustbot @ehuss @bors @rust-timer