Skip to content

Stabilize is_some_and#110019

Merged
bors merged 1 commit intorust-lang:masterfrom
jplatte:jplatte/stabilize-is-some-and
Apr 7, 2023
Merged

Stabilize is_some_and#110019
bors merged 1 commit intorust-lang:masterfrom
jplatte:jplatte/stabilize-is-some-and

Conversation

@jplatte
Copy link
Contributor

@jplatte jplatte commented Apr 6, 2023 •
edited by Amanieu
Loading

This stabilizes the following public API:

impl<T> Option<T> {
    pub fn is_some_and(self, f: impl FnOnce(T) -> bool) -> bool;
}

impl<T, E> Result<T, E> {
    pub fn is_ok_and(self, f: impl FnOnce(T) -> bool) -> bool;
    pub fn is_err_and(self, f: impl FnOnce(E) -> bool) -> bool;
}

Closes #93050 (tracking issue).

@rustbot label +T-libs-api -T-libs

@rustbot
Copy link
Collaborator

rustbot commented Apr 6, 2023

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 6, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 6, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

The Miri subtree was changed

cc @rust-lang/miri

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 6, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jplatte

This comment was marked as outdated.

Sign in to view
@jplatte jplatte force-pushed the jplatte/stabilize-is-some-and branch from 66edabe to 443928f Compare April 6, 2023 21:14
@asquared31415 asquared31415 mentioned this pull request Apr 6, 2023
Closed
8 tasks
@Amanieu
Copy link
Member

Amanieu commented Apr 6, 2023

I've updated the PR description with the correct signatures with closures taking T by value.

@Amanieu
Copy link
Member

Amanieu commented Apr 6, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 6, 2023

📌 Commit 443928f has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2023
@bors
Copy link
Collaborator

bors commented Apr 7, 2023

⌛ Testing commit 443928f with merge b6f6104...

@bors
Copy link
Collaborator

bors commented Apr 7, 2023

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing b6f6104 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 7, 2023
@bors bors merged commit b6f6104 into rust-lang:master Apr 7, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 7, 2023
@rust-timer
Copy link
Collaborator

rust-timer commented Apr 7, 2023

Finished benchmarking commit (b6f6104): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.5% [2.1%, 4.4%] 3
Regressions ❌
(secondary)		 2.2% [1.4%, 3.0%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 3.5% [2.1%, 4.4%] 3

Cycles

This benchmark run did not return any relevant results for this metric.

@jplatte jplatte deleted the jplatte/stabilize-is-some-and branch April 7, 2023 13:50
@WaffleLapkin WaffleLapkin removed the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 18, 2023
This was referenced Sep 14, 2023
Merged
Merged
@bosswnx bosswnx mentioned this pull request Feb 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joshtriplett joshtriplett

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.70.0

Development

Successfully merging this pull request may close these issues.

Tracking Issue for Option::is_some_and and Result::is_{ok,err}_and

8 participants

@jplatte @rustbot @rust-log-analyzer @Amanieu @bors @rust-timer @joshtriplett @WaffleLapkin