Merged
Conversation
OpenHarmony uses emulated TLS, which doesn't link properly when using thread-local variables across crate boundaries with `-C prefer-dynamic`. This PR makes thread_local! use pthreads directly instead.
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
…chenkov Deny `use`ing tool paths Fixes rust-lang#109853 Fixes rust-lang#109147
…tic, r=eholk Don't ICE when encountering `dyn*` in statics or consts Since we have properly implemented `dyn*` support in CTFE (rust-lang#107728), let's not ICE here anymore. Fixes rust-lang#105777 r? `@eholk`
…sleywiser Disable `has_thread_local` on OpenHarmony OpenHarmony uses emulated TLS, which doesn't link properly when using thread-local variables across crate boundaries with `-C prefer-dynamic`. This PR makes thread_local! use pthreads directly instead.
write threads info into log only when debugging The current tracing log will unconditionally write thread information during parallel compilation, which sometimes confuses some normal output log information This fixes the UI test failure of: ``` [ui] tests/ui/consts/const_in_pattern/issue-73431.rs ``` Updates rust-lang#75760
…errors Add regression test for rust-lang#80409 r? ``@compiler-errors`` Closes rust-lang#80409
…errors Add regression test for rust-lang#86351 r? `@compiler-errors` Closes rust-lang#86351
…mall-screen, r=notriddle rustdoc: Improve logo display very small screen Before:  After:  r? `@notriddle`
Member
Author
|
@bors r+ p=7 rollup=never |
Collaborator
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR: previous master: 2eaeb1eee1 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Collaborator
|
Finished benchmarking commit (8c7ad16): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
useing tool paths #109909 (Denyuseing tool paths)dyn*in statics or consts #109921 (Don't ICE when encounteringdyn*in statics or consts)has_thread_localon OpenHarmony #109922 (Disablehas_thread_localon OpenHarmony)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup