Skip to content

Update cargo#107778

Merged
bors merged 1 commit intorust-lang:masterfrom
weihanglo:update-cargo
Feb 8, 2023
Merged

Update cargo#107778
bors merged 1 commit intorust-lang:masterfrom
weihanglo:update-cargo

Conversation

@weihanglo
Copy link
Member

@weihanglo weihanglo commented Feb 7, 2023

12 commits in e84a7928d93a31f284b497c214a2ece69b4d7719..82c3bb79e3a19a5164e33819ef81bfc2c984bc56 2023-01-31 22:18:09 +0000 to 2023-02-04 22:52:16 +0000

r? @ghost

@weihanglo
Update cargo
6f38fd5 
12 commits in e84a7928d93a31f284b497c214a2ece69b4d7719..82c3bb79e3a19a5164e33819ef81bfc2c984bc56
2023-01-31 22:18:09 +0000 to 2023-02-04 22:52:16 +0000

- util toml targets: Do not infer directory as a file (rust-lang/cargo#11678)
- Add more guidance on how to implement unstable features (rust-lang/cargo#11675)
- Fix unstable chapter layout for codegen-backend (rust-lang/cargo#11676)
- refactor: mod.rs over "name".rs for consistency (rust-lang/cargo#11673)
- Verify source before recompile (rust-lang/cargo#11672)
- doc: more doc comments and intra-doc links (rust-lang/cargo#11669)
- Turn off debuginfo for build dependencies v2 (rust-lang/cargo#11252)
- config: Deny CARGO_HOME in [env] table (fixes rust-lang/cargo#11590) (rust-lang/cargo#11644)
- Fix the wrong comment (rust-lang/cargo#11651)
- Add partial support for SSH known hosts markers (rust-lang/cargo#11635)
- Replace `winapi` with `windows-sys` crate. (rust-lang/cargo#11656)
- Handle .cargo-ok being truncated (rust-lang/cargo#11665)
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 7, 2023
@rustbot
Copy link
Collaborator

rustbot commented Feb 7, 2023

These commits modify the Cargo.lock file. Random changes to Cargo.lock can be introduced when switching branches and rebasing PRs.
This was probably unintentional and should be reverted before this PR is merged.

If this was intentional then you can ignore this comment.

Some changes occurred in src/tools/cargo

cc @ehuss

@weihanglo
Copy link
Member Author

weihanglo commented Feb 7, 2023

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Feb 7, 2023

📌 Commit 6f38fd5 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2023
@bors
Copy link
Collaborator

bors commented Feb 8, 2023

⌛ Testing commit 6f38fd5 with merge 7ba4e95...

@bors
Copy link
Collaborator

bors commented Feb 8, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 7ba4e95 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 8, 2023
@bors bors merged commit 7ba4e95 into rust-lang:master Feb 8, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 8, 2023
@weihanglo weihanglo deleted the update-cargo branch February 8, 2023 07:47
@bors bors mentioned this pull request Feb 8, 2023
Merged
@rust-timer
Copy link
Collaborator

rust-timer commented Feb 8, 2023

Finished benchmarking commit (7ba4e95): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.1% [0.4%, 1.5%] 3
Regressions ❌
(secondary)		 3.3% [1.7%, 4.4%] 8
Improvements ✅
(primary)		 -2.4% [-7.7%, -0.4%] 8
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.4% [-7.7%, 1.5%] 11

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.2% [2.2%, 2.2%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.7% [-3.3%, -2.1%] 2
All ❌✅ (primary) 2.2% [2.2%, 2.2%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.6% [-5.8%, -1.5%] 3
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -3.6% [-5.8%, -1.5%] 3

@rustbot rustbot added the perf-regression Performance regression. label Feb 8, 2023
@lqd
Copy link
Member

lqd commented Feb 8, 2023

Note: the cranelift-codegen, keccak, and externs regressions are because these benchmarks are currently noisy.

@lukas-code lukas-code mentioned this pull request Feb 8, 2023
Closed
@rylev
Copy link
Member

rylev commented Feb 14, 2023

Marking this as triaged since the regressions are mostly noise

@rustbot label: perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Feb 14, 2023
@ryoqun ryoqun mentioned this pull request Apr 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.69.0

Development

Successfully merging this pull request may close these issues.

Deny setting CARGO_HOME in [env] table

6 participants

@weihanglo @rustbot @bors @rust-timer @lqd @rylev