Skip to content

Revert "Don't set is_preview for clippy and rustfmt"#104950

Merged
bors merged 1 commit intorust-lang:masterfrom
jyn514:revert-preview
Nov 27, 2022
Merged

Revert "Don't set is_preview for clippy and rustfmt"#104950
bors merged 1 commit intorust-lang:masterfrom
jyn514:revert-preview

Conversation

@jyn514
Copy link
Member

@jyn514 jyn514 commented Nov 26, 2022

This reverts commit fb3e724, which broke rustup update for anyone with clippy or rustfmt installed.

Fixes #104930.

r? @Mark-Simulacrum

@bors p=50 fixes nightly

@jyn514
Revert "Don't set is_preview for clippy and rustfmt"
c80b484 
This reverts commit fb3e724, which broke `rustup update` for anyone with clippy or rustfmt installed.
@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 26, 2022
@jyn514
Copy link
Member Author

jyn514 commented Nov 26, 2022

@bors p=50 fixes nightly

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Nov 26, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 26, 2022

📌 Commit c80b484 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2022
@bors
Copy link
Collaborator

bors commented Nov 26, 2022

⌛ Testing commit c80b484 with merge 240dcc0f30c65b0750400174a16ab763f4b5d8c5...

@bors
Copy link
Collaborator

bors commented Nov 26, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 26, 2022
@jyn514
Copy link
Member Author

jyn514 commented Nov 26, 2022

looks spurious

---- [ui] src/test/ui/traits/predicate_can_apply-hang.rs stdout ----

error: Error: expected failure status (Some(1)) but received status None.
status: signal: 6 (SIGABRT) (core dumped)
Some tests failed in compiletest suite=ui mode=ui host=i686-unknown-linux-gnu target=i686-unknown-linux-gnu
command: "/checkout/obj/build/i686-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/traits/predicate_can_apply-hang.rs" "-Zthreads=1" "--target=i686-unknown-linux-gnu" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/i686-unknown-linux-gnu/test/ui/traits/predicate_can_apply-hang" "-A" "unused" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/i686-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/test/ui/traits/predicate_can_apply-hang/auxiliary"
stdout: none
--- stderr -------------------------------
memory allocation of 713031696 bytes failed
------------------------------------------

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2022
@jyn514 jyn514 mentioned this pull request Nov 26, 2022
Merged
@bors
Copy link
Collaborator

bors commented Nov 26, 2022

⌛ Testing commit c80b484 with merge c0e9c86...

@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Nov 26, 2022

The job i686-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
failures:

---- [ui] src/test/ui/typeck/hang-in-overflow.rs stdout ----

error: Error: expected failure status (Some(1)) but received status None.
status: signal: 6 (SIGABRT) (core dumped)
command: "/checkout/obj/build/i686-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/typeck/hang-in-overflow.rs" "-Zthreads=1" "--target=i686-unknown-linux-gnu" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/i686-unknown-linux-gnu/test/ui/typeck/hang-in-overflow" "-A" "unused" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/i686-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/test/ui/typeck/hang-in-overflow/auxiliary"
stdout: none
--- stderr -------------------------------
memory allocation of 713031696 bytes failed


---- [ui] src/test/ui/traits/predicate_can_apply-hang.rs stdout ----


error: Error: expected failure status (Some(1)) but received status None.
status: signal: 6 (SIGABRT) (core dumped)
Some tests failed in compiletest suite=ui mode=ui host=i686-unknown-linux-gnu target=i686-unknown-linux-gnu
command: "/checkout/obj/build/i686-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/traits/predicate_can_apply-hang.rs" "-Zthreads=1" "--target=i686-unknown-linux-gnu" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/i686-unknown-linux-gnu/test/ui/traits/predicate_can_apply-hang" "-A" "unused" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/i686-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/test/ui/traits/predicate_can_apply-hang/auxiliary"
stdout: none
--- stderr -------------------------------
memory allocation of 713031696 bytes failed



failures:

@jyn514 jyn514 mentioned this pull request Nov 26, 2022
Closed
@bors
Copy link
Collaborator

bors commented Nov 27, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing c0e9c86 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 27, 2022
@bors bors merged commit c0e9c86 into rust-lang:master Nov 27, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 27, 2022
@rust-timer
Copy link
Collaborator

rust-timer commented Nov 27, 2022

Finished benchmarking commit (c0e9c86): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.3% [1.7%, 2.8%] 6
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.3% [1.7%, 2.8%] 6

@jyn514 jyn514 deleted the revert-preview branch November 27, 2022 02:50
@cuviper cuviper mentioned this pull request Jan 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.67.0

Development

Successfully merging this pull request may close these issues.

rustfmt / clippy component missing

6 participants

@jyn514 @Mark-Simulacrum @bors @rust-log-analyzer @rust-timer @rustbot