Merged
Conversation
`dist` creates a `rust-docs-json.tar.xz` tarfile. But build-manifest expected it to be named `rust-docs-json-preview.tar.xz`. Change build-manifest to allow the name without the `-preview` suffix. This also adds `rust-docs-json` to the `rust` component. I'm not quite sure why it exists, but rustup uses it to determine which components are available.
…Simulacrum Package `rust-docs-json` into nightly components (take 3) `dist` creates a `rust-docs-json.tar.xz` tarfile. But build-manifest expected it to be named `rust-docs-json-preview.tar.xz`. Change build-manifest to allow the name without the `-preview` suffix. I haven't actually tested this :( build-manifest is a pain to run locally.
… r=oli-obk Check generic argument compatibility when projecting assoc ty Fixes rust-lang#102114
…-dead Only allow ~const bounds for traits with #[const_trait] r? `@fee1-dead`
…02605, r=compiler-errors Add test for rust-lang#102605 Fixes rust-lang#102605
It's not about types or consts, but the lack of regions pulled out of rust-lang#101900 which adds a fourth kind of non-lifetime generic parameter, and the naming of these methods would get ridiculous.
resolve instance: missing value to `delay_span_bug`
Member
Author
|
@bors r+ rollup=never p=6 |
Collaborator
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR: previous master: 02cd79afb8 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Oct 4, 2022
Merged
This was referenced Oct 4, 2022
Collaborator
|
Finished benchmarking commit (01af504): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
rust-docs-jsoninto nightly components (take 3) #102241 (Packagerust-docs-jsoninto nightly components (take 3))delay_span_bug#102653 (resolve instance: missing value todelay_span_bug)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup