-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
Open
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.Category: This is a bug.O-wasmTarget: WASM (WebAssembly), http://webassembly.org/Target: WASM (WebAssembly), http://webassembly.org/
Description
This is a follow-up to #151431 (comment) which suggested to open a separate issue for discussing end-to-end, rmake-based wasm testing of #[export_visibility] and what would be necessary for that.
IIUC this requires:
- Enabling
"wasm"crate feature of theobjectcrate dependency insrc/tools/run-make-support/Cargo.toml- something like:object = { version = "0.37", features = ["read", "compression", "wasm"] } - Tweaking
fn dynamic_lib_prefixandfn dynamic_lib_extensioninsrc/tools/run-make-support/src/artifact_names.rsto use WASM-related values fromlibrary/std/src/sys/env_consts.rs - Ensure that
exported_dynamic_symbol_namesworks for wasm. It usesobject::File::exports, which isn't implemented yet for wasm (as pointed out in Add new unstable attribute:#[export_visibility = ...]. #151431 (comment))
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.Category: This is a bug.O-wasmTarget: WASM (WebAssembly), http://webassembly.org/Target: WASM (WebAssembly), http://webassembly.org/