Skip to content

Tracking issue: WASM rmake test coverage for #[export_visibility] #153364

@anforowicz

Description

@anforowicz

This is a follow-up to #151431 (comment) which suggested to open a separate issue for discussing end-to-end, rmake-based wasm testing of #[export_visibility] and what would be necessary for that.

IIUC this requires:

  • Enabling "wasm" crate feature of the object crate dependency in src/tools/run-make-support/Cargo.toml - something like: object = { version = "0.37", features = ["read", "compression", "wasm"] }
  • Tweaking fn dynamic_lib_prefix and fn dynamic_lib_extension in src/tools/run-make-support/src/artifact_names.rs to use WASM-related values from library/std/src/sys/env_consts.rs
  • Ensure that exported_dynamic_symbol_names works for wasm. It uses object::File::exports, which isn't implemented yet for wasm (as pointed out in Add new unstable attribute: #[export_visibility = ...]. #151431 (comment))

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.O-wasmTarget: WASM (WebAssembly), http://webassembly.org/

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions