-
-
Notifications
You must be signed in to change notification settings - Fork 15k
move Alias[Ty|Const|Term]Kind into Alias[Ty|Const|Term], generalize to not require just a DefId #152245
Copy link
Copy link
Open
Labels
A-associated-itemsArea: Associated items (types, constants & functions)Area: Associated items (types, constants & functions)A-const-genericsArea: const generics (parameters and arguments)Area: const generics (parameters and arguments)A-type-systemArea: Type systemArea: Type systemC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.F-inherent_associated_types`#![feature(inherent_associated_types)]``#![feature(inherent_associated_types)]`F-min_generic_const_args`#![feature(min_generic_const_args)]``#![feature(min_generic_const_args)]`T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.T-typesRelevant to the types team, which will review and decide on the PR/issue.Relevant to the types team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-associated-itemsArea: Associated items (types, constants & functions)Area: Associated items (types, constants & functions)A-const-genericsArea: const generics (parameters and arguments)Area: const generics (parameters and arguments)A-type-systemArea: Type systemArea: Type systemC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.F-inherent_associated_types`#![feature(inherent_associated_types)]``#![feature(inherent_associated_types)]`F-min_generic_const_args`#![feature(min_generic_const_args)]``#![feature(min_generic_const_args)]`T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.T-typesRelevant to the types team, which will review and decide on the PR/issue.Relevant to the types team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
ty::Tyhas aAlias(AliasTyKind, DefId, GenericArgs)variant, whereasty::Constjust hasUnevaluated(DefId, GenericArgs).With mGCA we now have more than just anon consts in
Unevaluatedand have ways of normalizing that are not by invoking CTFE so this naming no longer makes sense. We're also starting to write code that wants to know what kind of const alias its interacting with (e.g. a projection, inherent, free, etc). This is really easy to check with types but with const generics we have to write awkward code matching onDefKinds and parents.I expect consts will probably want to go one step further than types and have different representations for different kinds of unnormalized consts. E.g.
I'm not sure exactly what we should call
Bikeshed/BikeshedConst, maybe justExprworks idk :3This issue has been assigned to @khyperia via this comment.