Skip to content

Commit eadb1ca

Browse files
rust-timerrust-timer
authored
Unrolled build for #154599
Rollup merge of #154599 - folkertdev:varargs-without-pattern-in-deps, r=mati865 report the `varargs_without_pattern` lint in deps tracking issue: #44930 After discussion in rust-lang/reference#2177 (comment). Based on #143619 (comment) there was only one actual impacted crate https://crates.io/crates/binrw. The issue was fixed in jam1garner/binrw#342, and has since been released jam1garner/binrw#342 (comment). Hence we may as well report this loudly. r? @ghost
2 parents d227e48 + 7c4cf96 commit eadb1ca

4 files changed

Lines changed: 150 additions & 4 deletions

File tree

‎compiler/rustc_lint_defs/src/builtin.rs‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5560,15 +5560,16 @@ declare_lint! {
55605560
///
55615561
/// ### Example
55625562
///
5563-
/// ```rust
5563+
#[cfg_attr(bootstrap, doc = "```rust")]
5564+
#[cfg_attr(not(bootstrap), doc = "```rust,compile_fail")]
55645565
/// // Using `...` in non-foreign function definitions is unstable, however stability is
55655566
/// // currently only checked after attributes are expanded, so using `#[cfg(false)]` here will
55665567
/// // allow this to compile on stable Rust.
55675568
/// #[cfg(false)]
55685569
/// fn foo(...) {
55695570
///
55705571
/// }
5571-
/// ```
5572+
#[doc = "```"]
55725573
///
55735574
/// {{produces}}
55745575
///
@@ -5592,11 +5593,11 @@ declare_lint! {
55925593
///
55935594
/// [future-incompatible]: ../index.md#future-incompatible-lints
55945595
pub VARARGS_WITHOUT_PATTERN,
5595-
Warn,
5596+
Deny,
55965597
"detects usage of `...` arguments without a pattern in non-foreign items",
55975598
@future_incompatible = FutureIncompatibleInfo {
55985599
reason: fcw!(FutureReleaseError #145544),
5599-
report_in_deps: false,
5600+
report_in_deps: true,
56005601
};
56015602
}
56025603

‎tests/ui/c-variadic/parse-errors.e2015.stderr‎

Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,3 +44,60 @@ LL | unsafe extern "C" fn f(_: ...) {}
4444

4545
error: aborting due to 3 previous errors
4646

47+
Future incompatibility report: Future breakage diagnostic:
48+
error: missing pattern for `...` argument
49+
--> $DIR/parse-errors.rs:11:28
50+
|
51+
LL | unsafe extern "C" fn f(...) {
52+
| ^^^
53+
|
54+
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
55+
= note: for more information, see issue #145544 <https://github.com/rust-lang/rust/issues/145544>
56+
note: the lint level is defined here
57+
--> $DIR/parse-errors.rs:7:9
58+
|
59+
LL | #![deny(varargs_without_pattern)]
60+
| ^^^^^^^^^^^^^^^^^^^^^^^
61+
help: name the argument, or use `_` to continue ignoring it
62+
|
63+
LL | unsafe extern "C" fn f(_: ...) {
64+
| ++
65+
66+
Future breakage diagnostic:
67+
error: missing pattern for `...` argument
68+
--> $DIR/parse-errors.rs:14:32
69+
|
70+
LL | unsafe extern "C" fn f(...) {}
71+
| ^^^
72+
|
73+
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
74+
= note: for more information, see issue #145544 <https://github.com/rust-lang/rust/issues/145544>
75+
note: the lint level is defined here
76+
--> $DIR/parse-errors.rs:7:9
77+
|
78+
LL | #![deny(varargs_without_pattern)]
79+
| ^^^^^^^^^^^^^^^^^^^^^^^
80+
help: name the argument, or use `_` to continue ignoring it
81+
|
82+
LL | unsafe extern "C" fn f(_: ...) {}
83+
| ++
84+
85+
Future breakage diagnostic:
86+
error: missing pattern for `...` argument
87+
--> $DIR/parse-errors.rs:20:32
88+
|
89+
LL | unsafe extern "C" fn f(...) {}
90+
| ^^^
91+
|
92+
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
93+
= note: for more information, see issue #145544 <https://github.com/rust-lang/rust/issues/145544>
94+
note: the lint level is defined here
95+
--> $DIR/parse-errors.rs:7:9
96+
|
97+
LL | #![deny(varargs_without_pattern)]
98+
| ^^^^^^^^^^^^^^^^^^^^^^^
99+
help: name the argument, or use `_` to continue ignoring it
100+
|
101+
LL | unsafe extern "C" fn f(_: ...) {}
102+
| ++
103+

‎tests/ui/c-variadic/parse-errors.e2018.stderr‎

Lines changed: 76 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,3 +57,79 @@ LL | unsafe extern "C" fn f(_: ...) {}
5757

5858
error: aborting due to 4 previous errors
5959

60+
Future incompatibility report: Future breakage diagnostic:
61+
error: missing pattern for `...` argument
62+
--> $DIR/parse-errors.rs:11:28
63+
|
64+
LL | unsafe extern "C" fn f(...) {
65+
| ^^^
66+
|
67+
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
68+
= note: for more information, see issue #145544 <https://github.com/rust-lang/rust/issues/145544>
69+
note: the lint level is defined here
70+
--> $DIR/parse-errors.rs:7:9
71+
|
72+
LL | #![deny(varargs_without_pattern)]
73+
| ^^^^^^^^^^^^^^^^^^^^^^^
74+
help: name the argument, or use `_` to continue ignoring it
75+
|
76+
LL | unsafe extern "C" fn f(_: ...) {
77+
| ++
78+
79+
Future breakage diagnostic:
80+
error: missing pattern for `...` argument
81+
--> $DIR/parse-errors.rs:14:32
82+
|
83+
LL | unsafe extern "C" fn f(...) {}
84+
| ^^^
85+
|
86+
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
87+
= note: for more information, see issue #145544 <https://github.com/rust-lang/rust/issues/145544>
88+
note: the lint level is defined here
89+
--> $DIR/parse-errors.rs:7:9
90+
|
91+
LL | #![deny(varargs_without_pattern)]
92+
| ^^^^^^^^^^^^^^^^^^^^^^^
93+
help: name the argument, or use `_` to continue ignoring it
94+
|
95+
LL | unsafe extern "C" fn f(_: ...) {}
96+
| ++
97+
98+
Future breakage diagnostic:
99+
error: missing pattern for `...` argument
100+
--> $DIR/parse-errors.rs:20:32
101+
|
102+
LL | unsafe extern "C" fn f(...) {}
103+
| ^^^
104+
|
105+
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
106+
= note: for more information, see issue #145544 <https://github.com/rust-lang/rust/issues/145544>
107+
note: the lint level is defined here
108+
--> $DIR/parse-errors.rs:7:9
109+
|
110+
LL | #![deny(varargs_without_pattern)]
111+
| ^^^^^^^^^^^^^^^^^^^^^^^
112+
help: name the argument, or use `_` to continue ignoring it
113+
|
114+
LL | unsafe extern "C" fn f(_: ...) {}
115+
| ++
116+
117+
Future breakage diagnostic:
118+
error: missing pattern for `...` argument
119+
--> $DIR/parse-errors.rs:26:32
120+
|
121+
LL | unsafe extern "C" fn f(...) {}
122+
| ^^^
123+
|
124+
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
125+
= note: for more information, see issue #145544 <https://github.com/rust-lang/rust/issues/145544>
126+
note: the lint level is defined here
127+
--> $DIR/parse-errors.rs:7:9
128+
|
129+
LL | #![deny(varargs_without_pattern)]
130+
| ^^^^^^^^^^^^^^^^^^^^^^^
131+
help: name the argument, or use `_` to continue ignoring it
132+
|
133+
LL | unsafe extern "C" fn f(_: ...) {}
134+
| ++
135+

‎tests/ui/thir-print/c-variadic.stderr‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
Future incompatibility report: Future breakage diagnostic:
2+
warning: missing pattern for `...` argument
3+
--> $DIR/c-variadic.rs:7:34
4+
|
5+
LL | unsafe extern "C" fn foo(_: i32, ...) {}
6+
| ^^^
7+
|
8+
help: name the argument, or use `_` to continue ignoring it
9+
|
10+
LL | unsafe extern "C" fn foo(_: i32, _: ...) {}
11+
| ++
12+

0 commit comments

Comments
 (0)