Unrolled build for #158698

rust-timer · web-flow · commit 4fad40b8f9c5 · 2026-07-06T01:55:23.000+02:00
Rollup merge of #158698 - addiesh:oh-a-visitor, r=oli-obk Update TypeVisitable implementation r? oli-obk `TypeVisitable` had some redundant/specific implementations which I've generalized and extended to be a little more broad. Boxed slices now derive their impl from `Box<T>` and `[T]` (instead of `Box<[T]>`), and an implementation for fixed-size arrays was added cuz [I needed that](https://github.com/rust-lang/rust/pull/158632/changes#diff-f1c6da80803e15c8bca78842a05972878a299c2b375dab82635e1124cd0ce08fR539). Also removed `Sized` restrictions on `&T` and `Box<T>` to make it all work. Could probably stand to do the same for some other types, but that wasn't necessary for my changes.
diff --git a/compiler/rustc_type_ir/src/visit.rs b/compiler/rustc_type_ir/src/visit.rs
@@ -167,7 +167,7 @@ impl<I: Interner, T: TypeVisitable<I>, E: TypeVisitable<I>> TypeVisitable<I> for
     }
 }
 
-impl<I: Interner, T: TypeVisitable<I>> TypeVisitable<I> for &T {
+impl<I: Interner, T: TypeVisitable<I> + ?Sized> TypeVisitable<I> for &T {
     fn visit_with<V: TypeVisitor<I>>(&self, visitor: &mut V) -> V::Result {
         (**self).visit_with(visitor)
     }
@@ -179,7 +179,7 @@ impl<I: Interner, T: TypeVisitable<I>> TypeVisitable<I> for Arc<T> {
     }
 }
 
-impl<I: Interner, T: TypeVisitable<I>> TypeVisitable<I> for Box<T> {
+impl<I: Interner, T: TypeVisitable<I> + ?Sized> TypeVisitable<I> for Box<T> {
     fn visit_with<V: TypeVisitor<I>>(&self, visitor: &mut V) -> V::Result {
         (**self).visit_with(visitor)
     }
@@ -209,14 +209,14 @@ impl<I: Interner, T: TypeVisitable<I>, const N: usize> TypeVisitable<I> for Smal
 // `TypeFoldable` isn't impl'd for `&[T]`. It doesn't make sense in the general
 // case, because we can't return a new slice. But note that there are a couple
 // of trivial impls of `TypeFoldable` for specific slice types elsewhere.
-impl<I: Interner, T: TypeVisitable<I>> TypeVisitable<I> for &[T] {
+impl<I: Interner, T: TypeVisitable<I>> TypeVisitable<I> for [T] {
     fn visit_with<V: TypeVisitor<I>>(&self, visitor: &mut V) -> V::Result {
         walk_visitable_list!(visitor, self.iter());
         V::Result::output()
     }
 }
 
-impl<I: Interner, T: TypeVisitable<I>> TypeVisitable<I> for Box<[T]> {
+impl<const N: usize, I: Interner, T: TypeVisitable<I>> TypeVisitable<I> for [T; N] {
     fn visit_with<V: TypeVisitor<I>>(&self, visitor: &mut V) -> V::Result {
         walk_visitable_list!(visitor, self.iter());
         V::Result::output()

Original file line number	Diff line number	Diff line change
`@@ -167,7 +167,7 @@ impl<I: Interner, T: TypeVisitable<I>, E: TypeVisitable<I>> TypeVisitable<I> for`
`167`	`167`	`}`
`168`	`168`	`}`
`169`	`169`
`170`		`-impl<I: Interner, T: TypeVisitable<I>> TypeVisitable<I> for &T {`
	`170`	`+impl<I: Interner, T: TypeVisitable<I> + ?Sized> TypeVisitable<I> for &T {`
`171`	`171`	`fn visit_with<V: TypeVisitor<I>>(&self, visitor: &mut V) -> V::Result {`
`172`	`172`	`(**self).visit_with(visitor)`
`173`	`173`	`}`
`@@ -179,7 +179,7 @@ impl<I: Interner, T: TypeVisitable<I>> TypeVisitable<I> for Arc<T> {`
`179`	`179`	`}`
`180`	`180`	`}`
`181`	`181`
`182`		`-impl<I: Interner, T: TypeVisitable<I>> TypeVisitable<I> for Box<T> {`
	`182`	`+impl<I: Interner, T: TypeVisitable<I> + ?Sized> TypeVisitable<I> for Box<T> {`
`183`	`183`	`fn visit_with<V: TypeVisitor<I>>(&self, visitor: &mut V) -> V::Result {`
`184`	`184`	`(**self).visit_with(visitor)`
`185`	`185`	`}`
`@@ -209,14 +209,14 @@ impl<I: Interner, T: TypeVisitable<I>, const N: usize> TypeVisitable<I> for Smal`
`209`	`209`	// `TypeFoldable` isn't impl'd for `&[T]`. It doesn't make sense in the general
`210`	`210`	`// case, because we can't return a new slice. But note that there are a couple`
`211`	`211`	// of trivial impls of `TypeFoldable` for specific slice types elsewhere.
`212`		`-impl<I: Interner, T: TypeVisitable<I>> TypeVisitable<I> for &[T] {`
	`212`	`+impl<I: Interner, T: TypeVisitable<I>> TypeVisitable<I> for [T] {`
`213`	`213`	`fn visit_with<V: TypeVisitor<I>>(&self, visitor: &mut V) -> V::Result {`
`214`	`214`	`walk_visitable_list!(visitor, self.iter());`
`215`	`215`	`V::Result::output()`
`216`	`216`	`}`
`217`	`217`	`}`
`218`	`218`
`219`		`-impl<I: Interner, T: TypeVisitable<I>> TypeVisitable<I> for Box<[T]> {`
	`219`	`+impl<const N: usize, I: Interner, T: TypeVisitable<I>> TypeVisitable<I> for [T; N] {`
`220`	`220`	`fn visit_with<V: TypeVisitor<I>>(&self, visitor: &mut V) -> V::Result {`
`221`	`221`	`walk_visitable_list!(visitor, self.iter());`
`222`	`222`	`V::Result::output()`