This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Closed
Conversation
Additionally, lock racer version. The upstream started to fuck up ABI.
Member
|
Thanks for the PR! The Racer version lock looks good, but we should not bump the other deps - there is a bit of an ongoing experiment there and we're not ready to use the newer versions in the RLS just yet. |
Contributor
Author
|
I have confirmed that the build passes and it should work as long as the modules are following semver. |
Member
|
Thanks for checking, but I would still rather not bump the versions until we know that is the direction we want to go in. There is also test failure here which may or may not be related. |
Contributor
Author
|
I'm going to close this as the new RLS crates needs porting. Instead, I will open another PR which simply upgrades (propers) dependencies, after rust-dev-tools/rls-vfs#15 is resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally, lock racer version. The upstream started to fuck up interface.
Cargo has bumped the version and broke the compatibility. The code is updated accordingly (untested, hope it works).
We should really pin things to crates.io, with exception of rls related crates.