This repository was archived by the owner on Dec 29, 2022. It is now read-only.
LsService::handle_message match replaced with macro#256
Merged
nrc merged 1 commit intorust-lang:masterfrom May 1, 2017
Merged
Conversation
Member
|
Thanks for the PR and apologies for the long wait for review - I've been away on parental leave the past few weeks. |
nrc
approved these changes
May 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #45.
For every
Method/Notificationenum we can either specify an arbitrary expression to evaluate when handling a message or use a default handler following existing convention:this.handler.<action_name>([id,] params, &*this.output).Few things to note:
trace_paramsas I think there may be better idea to handle an optional enum payload token intrace!calltrace!call are too long, but I figured it doesn't add to the logic itself, so throwing a one-liner just to inform of a trace is acceptableLsService::handle_message(along with initialparse_message,shut_downlogic etc.)