Conversation
|
Thank you, it's a great first PR! Since in our |
|
Thanks for your quick and detailed response. :) I missed that(because I didn't knew it is verifying this by static results). I'll fix that tomorrow. :) Too tired.. |
|
No worries, thanks! |
|
I think that should be it, but maybe I missed some tests(because I've got multiple ICEs while testing) although I've got |
|
Yeah, that's good. The ICE fix is pending at rust-lang/rust#57436, no need to worry about that. Just a heads up - it's good to include in the PR title what's the actual change (e.g. "Remove copyright headers") instead of the issue number. This way everyone can know at a glance what the PR is about and you're probably going to write
in the description anyway, so GitHub (and others!) knows what's the related issue. But that's super minor; thank you for your work! |
|
Thanks for the heads up. :) |
I noticed I forgot to push to a different branch, I'm sorry.
Furthermore, I needed to revert some rustfmt actions, where I was unsure whether they are wanted(the json formatting seems okay to me, but I can delete this on request).
fixes #1231