capi: Fix 'unused return value' warnings#882
Merged
BurntSushi merged 2 commits intorust-lang:masterfrom Jul 14, 2022
Merged
Conversation
Contributor
Author
|
Note: The |
BurntSushi
requested changes
Jul 14, 2022
| while let Some(ptr) = it.name_ptrs.pop(){ | ||
| CString::from_raw(ptr); | ||
| while let Some(ptr) = it.name_ptrs.pop() { | ||
| drop(CString::from_raw(ptr)); |
Member
There was a problem hiding this comment.
We might as well go the whole nine yards here and add drop(..) around other calls to from_raw as well. e.g., Box::from_raw. Would you mind doing that as well?
Contributor
Author
There was a problem hiding this comment.
Thank you for the review comment. I searched Box::from_raw and applied the same fix at 1324f2d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo check --workspacereported the following warnings on my local machine.This PR fixes the warnings.
Environment