regex-lite: fix compilation of doctests on 32-bit architectures#1101
Merged
BurntSushi merged 1 commit intorust-lang:masterfrom Oct 10, 2023
decathorpe:master
Merged
regex-lite: fix compilation of doctests on 32-bit architectures#1101BurntSushi merged 1 commit intorust-lang:masterfrom decathorpe:master
BurntSushi merged 1 commit intorust-lang:masterfrom
decathorpe:master
Conversation
Returning early on non-64-bit architectures is not enough, since the doctest failed to compile due to two numeric literals being too large for usize on 32-bit architectures.
BurntSushi
approved these changes
Oct 10, 2023
Member
BurntSushi
left a comment
There was a problem hiding this comment.
Hah, oh man, this is rough. We'll see how this goes, but I really really loathe these sorts of hacks to get doc tests working. Especially when I can't test them in CI.
But happy to play along for now and try out this whack-a-mole approach. Thank you!!!
Member
|
This PR is on crates.io in |
Contributor
Author
|
Yeah, I agree that this is not ideal :( Thanks for merging + the new release! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup for #1041. Returning early on non-64-bit architectures is not enough in this case, since the doctest actually fails to compile due to two numeric literals being too large for
usizeon 32-bit architectures.With this change, "lib" and "doc" tests for the the regex-lite crate pass on all CPU architectures that I have access to.