regex-automata/test: ignore some tests in 32-bit targets#1040
Merged
BurntSushi merged 1 commit intomasterfrom Jul 12, 2023
Merged
regex-automata/test: ignore some tests in 32-bit targets#1040BurntSushi merged 1 commit intomasterfrom
BurntSushi merged 1 commit intomasterfrom
Conversation
One of these tests (the captures one) is very specific to 64-bit since it uses a numeric literal that is bigger than what can be fit into 32 bits. The other two tests, for determinize_size_limit, are not specific to 64-bit targets but do somewhat depend on the specific memory usages in play. We could probably find some limits that work for both 32-bit and 64-bit, but since 'cross' doesn't run doc tests, doing this is pretty annoying. So just ignore the tests. Fixes #1039
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of these tests (the captures one) is very specific to 64-bit since it uses a numeric literal that is bigger than what can be fit into 32 bits.
The other two tests, for determinize_size_limit, are not specific to 64-bit targets but do somewhat depend on the specific memory usages in play. We could probably find some limits that work for both 32-bit and 64-bit, but since 'cross' doesn't run doc tests, doing this is pretty annoying. So just ignore the tests.
Fixes #1039