Remove overflow panic from divrem and add basic docs to Simd<T, N>#243
Merged
workingjubilee merged 3 commits intomasterfrom Feb 9, 2022
Merged
Remove overflow panic from divrem and add basic docs to Simd<T, N>#243workingjubilee merged 3 commits intomasterfrom
workingjubilee merged 3 commits intomasterfrom
Conversation
8df0494 to
9658bd9
Compare
Includes some remarks in intrinsics.rs, generated while auditing the interface for remaining UB.
and other quirks like panicking and the equivalence to zipping and mapping binary ops
9658bd9 to
e628a29
Compare
calebzulawski
approved these changes
Feb 9, 2022
Member
calebzulawski
left a comment
There was a problem hiding this comment.
Looks good to me, just added some suggestions where I thought it could be a little clearer.
Co-authored-by: Caleb Zulawski <caleb.zulawski@gmail.com>
8250e2c to
5d52455
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This finishes normalizing
Simd<T, N>to being approximately equivalent toSimd<Wrapping<T>, N>for all implemented operations I can think of. It also documents this fact, allowing this to close #56.