Update for https://github.com/rust-lang/rust/pull/42959#32
Merged
Gankra merged 1 commit intorust-lang:masterfrom Aug 2, 2017
Merged
Update for https://github.com/rust-lang/rust/pull/42959#32Gankra merged 1 commit intorust-lang:masterfrom
Gankra merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
ping me when this is ready to land |
Contributor
Author
|
I suppose we still have to figure out which parts of #42959 are desired. In the meantime, could you push this to a branch of this repo so that https://travis-ci.org/rust-lang/rust/jobs/253789889 doesn’t fail to update the submodule? |
Gankra
approved these changes
Jul 14, 2017
Contributor
|
uhh is it possible for you to submit the PR to a branch? |
Contributor
Author
|
Yes, but a branch other than master needs to exist first. Or you can do something like |
Contributor
|
if only there were SOME WAY to not have to deal with circular dependencies.......................... |
Contributor
Contributor
|
#33 is the replacement for this |
Contributor
|
something something need to merge this to master properly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.