Skip testing targets that don't ship libstd#556
Merged
RalfJung merged 2 commits intorust-lang:masterfrom Dec 2, 2018
Merged
Conversation
RalfJung
reviewed
Dec 1, 2018
f7e2ca8 to
6180d99
Compare
RalfJung
reviewed
Dec 2, 2018
RalfJung
reviewed
Dec 2, 2018
6180d99 to
91f0b28
Compare
Member
|
Looks good, thanks! Will merge once CI is happy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you have weirder targets like
thumbv6m-none-eabiinstalled in your current toolchain thencompiletestcrashes because it doesn't know what os or architecture the target is:Then, after hacking
compiletestto run anyway, the tests fail because there is nostddistributed with the target.This change will fix the second issue by not attempting to run the tests if there is no
libstddistributed with the target, which has a side-effect of fixing the first issue for at least embedded targets. There may be other targets thatcompiletesthas an issue with, but do distributelibstd, but I can't see any easy way to deal with them.