Enable more validation tests#315
Merged
oli-obk merged 2 commits intorust-lang:masterfrom Aug 28, 2017
Merged
Conversation
Contributor
|
|
Contributor
|
Let's turn validation back off for these tests. |
Member
Author
|
Thanks, that looks right. I have an idea for how to fix #296; once I implemented that, I can reevaluate these tests. |
Member
Author
|
The one thing I do not understand at all is |
Member
Author
|
Turns out that was just a fluke on my end. I removed that commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rust-lang/rust#43457 got fixed :)