Conversation
Member
|
Does this add a command line flag? Or just another |
RalfJung
reviewed
Apr 25, 2022
Member
Those are the same thing? MIRIFLAGS is how you pass command line flags to the Miri driver when using the cargo wrapper. |
Member
|
Ah. I have only ever used the Cargo wrapper, this whole "Miri driver" thing is just something I hear you mention 😅 |
RalfJung
reviewed
Apr 30, 2022
RalfJung
reviewed
Apr 30, 2022
Member
|
r=me with the last 2 nits fixed. :) |
Contributor
Author
|
@bors r=RalfJung |
Contributor
|
📌 Commit 6dc6256 has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-actions |
This was referenced May 10, 2022
Comment on lines
259
to
315
|
|
||
| impl<'tcx> Default for FileHandler { | ||
| fn default() -> Self { | ||
| impl<'tcx> FileHandler { | ||
| pub(crate) fn new(drop_stdout_stderr: bool) -> FileHandler { | ||
| let mut handles: BTreeMap<_, Box<dyn FileDescriptor>> = BTreeMap::new(); | ||
| handles.insert(0i32, Box::new(io::stdin())); | ||
| handles.insert(1i32, Box::new(io::stdout())); | ||
| if drop_stdout_stderr { | ||
| handles.insert(0i32, Box::new(DevNull)); | ||
| handles.insert(1i32, Box::new(DevNull)); | ||
| } else { | ||
| handles.insert(0i32, Box::new(io::stdin())); | ||
| handles.insert(1i32, Box::new(io::stdout())); | ||
| } | ||
| handles.insert(2i32, Box::new(io::stderr())); | ||
| FileHandler { handles } |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is practical for tests that don't actually care about the output and thus don't want it intermingled with miri's warnings, errors or ICEs
fixes #2083