Support additional themes in config#2594
Conversation
|
Very nice, can you also copy over my Orange example to the test book as well, so that the PR can be fully superceded? |
|
Some drive-by comments: One issue we've had is that the I'd also like to understand a little more how other generators work. #2048 discusses that a little, but I haven't had time to read and understand. I'm just trying to understand what the tradeoffs or alternate designs are here. I also wonder what if the user wants to remove a stock theme, how do they do that? I assume this works with all the options in I've been slightly uncomfortable that there is some muddled terminology here. "theme" in mdbook is a directory that allows you to completely customize how a page is rendered. Then there is also a "color theme" which is just a css class and a selector. The two are only loosely releated, and I worry about the potential confusion around them. I don't know why it was structured that way. Otherwise seems like it would be fun to support this. |
|
☔ The latest upstream changes (possibly #2681) made this pull request unmergeable. Please resolve the merge conflicts. |
This removes the need for replacing all of index.hbs just to have a custom theme.
Closes #2048.