Resolve full file paths when copying files#1323
Merged
ehuss merged 2 commits intorust-lang:masterfrom Sep 22, 2020
iffyio:copy-symlinks
Merged
Resolve full file paths when copying files#1323ehuss merged 2 commits intorust-lang:masterfrom iffyio:copy-symlinks
ehuss merged 2 commits intorust-lang:masterfrom
iffyio:copy-symlinks
Conversation
Currently, the `copy_files` function doesn't support symlink files due to its use of `DirEntry::metadata` - To avoid this issue, this patch resolves the file path first before checking for metadata. Fixes #1157
azerupi
approved these changes
Sep 11, 2020
ehuss
approved these changes
Sep 22, 2020
Contributor
ehuss
left a comment
There was a problem hiding this comment.
Thanks for the PR!
This has the potential to be relatively risky, but I haven't been able to think of any specific problems. Windows users will need to enable Developer Mode, which I guess isn't too bad. There might be some risk that the user wants a symlink in the output directory, but since I believe that doesn't work today, this seems like a good/simple first step. I also think this will fail if there is a symlink cycle, but I believe most operating systems will detect that with an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
copy_filesfunction doesn't support symlink files due toits use of
DirEntry::metadata- To avoid this issue, this patchresolves the file path first before checking for metadata.
Fixes #1157
Fixes #1209