This repository was archived by the owner on Feb 5, 2019. It is now read-only.
Import of fastcomp commit 4105790f1549808c1f1daa5250b4ada5f41a5c02#52
Merged
brson merged 1 commit intorust-lang:rust-llvm-2016-07-09from Sep 30, 2016
Merged
Import of fastcomp commit 4105790f1549808c1f1daa5250b4ada5f41a5c02#52brson merged 1 commit intorust-lang:rust-llvm-2016-07-09from
brson merged 1 commit intorust-lang:rust-llvm-2016-07-09from
Conversation
This is a minimal import of the emscripten "fastcomp" LLVM patchset. All it contains is the target definitions necessary to create a TargetMachine with the correct data layout. With this rustc can emit LLVM IR that emcc will run through the PNaCl lagalizer and the JS backend to generate asm.js.
Member
|
Looks good to me! Could you also document here (or in the commit message) the steps you took to trim the commit down? Other than that feel free to merge how you see fit (is the merge button right here?) |
Author
|
I'd expect us not to have to make changes to this in the future, except for possibly updating the JSBackend data layout (emscripten is considering it), since acquiring the data layout is just about the only thing this patch does now. But here's what I did:
|
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minimal import of the emscripten "fastcomp" LLVM patchset.
All it contains is the target definitions necessary to create a
TargetMachine with the correct data layout. With this rustc can
emit LLVM IR that emcc will run through the PNaCl lagalizer and
the JS backend to generate asm.js.
r? @alexcrichton