This repository was archived by the owner on Feb 5, 2019. It is now read-only.
Stack probe support for x86#21
Closed
Zoxc wants to merge 3 commits intorust-lang:rust-llvm-2014-08-05from
Zoxc:rust-stprobe
Closed
Stack probe support for x86#21Zoxc wants to merge 3 commits intorust-lang:rust-llvm-2014-08-05from Zoxc:rust-stprobe
Zoxc wants to merge 3 commits intorust-lang:rust-llvm-2014-08-05from
Zoxc:rust-stprobe
Conversation
Member
|
This seems like some pretty serious infrastructure which will break Rust's compatibility with system LLVM versions. Have you attempted to upstream these changes in LLVM yet? Our current fork of LLVM is largely just optimizations which aren't necessary for Rust to work correctly, and we strive to be compatible with system LLVM installations wherever possible. |
This attribute is used to ensure the guard page is triggered on stack overflow. Stack frames larger than the guard page size will generate a call to __probestack to touch each page so the guard page won't be skipped.
Author
|
There's http://reviews.llvm.org/D4717 |
|
Should this be closed as abandoned? |
Author
|
Yeah. See rust-lang/rust#16012 for progress on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effort to fix rust-lang/rust#16012