This repository was archived by the owner on Feb 5, 2019. It is now read-only.
Misc #131
Merged
alexcrichton merged 2 commits intorust-lang:rust-llvm-release-8-0-0-v2from Nov 28, 2018
Merged
Conversation
…ifyCFG." This reverts commit 8381d3e.
The MergeFunctions pass was originally intended to emit aliases instead of thunks where possible (unnamed_addr). However, for a long time this functionality was behind a flag hardcoded to false, bitrotted and was eventually removed in r309313. Originally the functionality was first disabled in r108417 due to lack of support for aliases in Mach-O. I believe that this is no longer the case nowadays, but not really familiar with this area. In the interest of being conservative, this patch reintroduces the aliasing functionality behind a default disabled -mergefunc-use-aliases flag. Differential Revision: https://reviews.llvm.org/D53285 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@347407 91177308-0d34-0410-b5e6-96231b3b80d8
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixLLVM_ERROR when building serde_json in release + debuginfo mode rust#56265. An upstream patch is in the works, but it may take a while until the correct semantics are figured out. In the meantime we can safely revert this.fixrustc beta (1.28.0) generates unnecessary call instruction rust#52651. This is not time critical, but also safe to include here, because it requires code on the rustc side to enable.Edit: Use
fixto avoid auto-closing issues -- did GitHub get a lot more aggressive about this?