Skip to content

update to zlib-ng version 2.2.5#251

Merged
Byron merged 2 commits intorust-lang:mainfrom
folkertdev:zlib-ng-2.2.5
Nov 12, 2025
Merged

update to zlib-ng version 2.2.5#251
Byron merged 2 commits intorust-lang:mainfrom
folkertdev:zlib-ng-2.2.5

Conversation

@folkertdev
Copy link
Copy Markdown
Contributor

No description provided.

@Byron
Copy link
Copy Markdown
Member

Byron commented Nov 12, 2025

Thanks a lot for the update!

I will see to creating a new release.

@Byron Byron merged commit 6452d5d into rust-lang:main Nov 12, 2025
48 checks passed
@folkertdev
Copy link
Copy Markdown
Contributor Author

As a heads-up, zlib-ng did a bunch of modifications to their cmake files and compile setup, so users may see some new linker errors etc. when building from source. We're encountering a couple, at least: https://github.com/trifectatechfoundation/zlib-rs/actions/runs/19329002658.

I suspect this will be rare in practice, but it's something to keep an eye on.

@Byron
Copy link
Copy Markdown
Member

Byron commented Nov 14, 2025

Thanks for sharing!

It's interesting that the CI here didn't notice this, and I wonder if that's a shortcoming.
Thus far I haven't heard of issues, but if they multiple we can always yank the update.

@folkertdev
Copy link
Copy Markdown
Contributor Author

The solution, for us anyway, is to also provide a C++ compiler. Usually cmake will already find one, but we have some interesting cross-compilation setups where we need to provide one explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants