Disable neon for apple targets#231
Conversation
|
It would probably be good to add CI checking of |
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot for your help, it's much appreciated!
A local test showed that it does indeed compile now.
Also, from what I can tell, it already is compiled on all platforms using a matrix, but it's allowed to fail when the CC feature is enabled. Even though warnings are emitted, thus far I admit to not have noticed them.
|
That's true! I wonder if the tests further down run on libz-sys/.github/workflows/ci.yml Lines 161 to 170 in 223f565 |
Workaround for #230.
Don't really have time to look at this more in depth, so this just disables neon intrinsics for apple targets leaving the rest of them untouched. There's probably just a missing flag or something, but someone who actually has the will to compile for aarch64-apple-darwin can maybe figure that out.