Remove FreeBSD's CAP_UNUSED* and CAP_ALL* constants#4184
Merged
tgross35 merged 1 commit intorust-lang:mainfrom Dec 8, 2024
Merged
Remove FreeBSD's CAP_UNUSED* and CAP_ALL* constants#4184tgross35 merged 1 commit intorust-lang:mainfrom
tgross35 merged 1 commit intorust-lang:mainfrom
Conversation
They aren't stable across OS versions and don't have any legitimate use in applications. See rust-lang#4183 for the corresponding change to the libc-0.2 branch.
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
Contributor
Author
|
I think the failure on aarch64-linux-android is unrelated. |
tgross35
approved these changes
Dec 8, 2024
Contributor
tgross35
left a comment
There was a problem hiding this comment.
Thanks for the quick fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They aren't stable across OS versions and don't have any legitimate use in applications.
See #4183 for the corresponding change to the libc-0.2 branch.
Description
Remove unstable and non-useful definitions
Sources
This commit, for example, changed some of these constants in FreeBSD 15.
freebsd/freebsd-src@b165e9e
I was unable to find any applications using these constants with Github code search. Only libraries like this one that supplied bindings. I also audited every open source consumer of the capsicum-rs crate to ensure that none were using these constants.
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI