Use ::Option and not Option for pthread_jit_write_callback_t#2931
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 29, 2022
Merged
Use ::Option and not Option for pthread_jit_write_callback_t#2931bors merged 1 commit intorust-lang:masterfrom
::Option and not Option for pthread_jit_write_callback_t#2931bors merged 1 commit intorust-lang:masterfrom
Conversation
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
JohnTitor
approved these changes
Sep 29, 2022
Member
|
Thanks! @bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
Member
|
@thomcc 0.2.134 is now available including this: https://crates.io/crates/libc/0.2.134 |
Member
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pthread_jit_write_callback_ttype alias (introduced by #2896) usesOptionrather than::Option, which causes problems when trying to update thelibcdependency thatstdhas.(Please cut a release after merging this <3)