Add confstr and guaranteed _CS_* constants on apple#2883
Merged
bors merged 1 commit intorust-lang:masterfrom Aug 23, 2022
Merged
Add confstr and guaranteed _CS_* constants on apple#2883bors merged 1 commit intorust-lang:masterfrom
confstr and guaranteed _CS_* constants on apple#2883bors merged 1 commit intorust-lang:masterfrom
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. Please see the contribution instructions for more information. |
This was referenced Aug 20, 2022
JohnTitor
approved these changes
Aug 23, 2022
Member
|
Thanks! @bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I actually just want
_CS_DARWIN_USER_TEMP_DIR, and theconfstrfunction, but I also have added the other "guaranteed"_CS_*values (e.g. present in the output ofman confstr).This is apparently a POSIX API but I have no idea which other platforms support it, nor what values should be provided. It's somewhat important on Darwin (the only way to access the user temp dir), but I'm not sure what other use it has, so I've only provided it on Darwin.
There are a few other constants in Darwin
unistd.h, but they're omitted since they're only conditionally present, and they provide values that... don't actually work1. As a result, I've only provided the ones documented byconfstrdocumentation.Footnotes
For example,
_CS_POSIX_V6_LPBIG_OFFBIG_CFLAGSnominally provides values that can be passed to a c compiler, but it gives-W 64for me, which does not seem to work withclang. ↩