Use cfg(target_has_atomic) on no-std targets#2811
Merged
Conversation
Member
Author
|
FYI @MabezDev |
Merged
Member
Author
|
Published in 0.3.30. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
cfg(target_has_atomic)oncfg(target_os = "none")targets.cfg(target_has_atomic)is only actually needed oncfg(target_os = "none")targets since CAS is one of the requirements of the std, and no-std targets other thancfg(target_os = "none")targets provide CAS.This increases the MSRV of the
cfg(target_os = "none")targets to Rust 1.60, but since they are all tier2/tier3 targets in rustc and those use cases usually require at least 1.59 for inline-asm, it would be acceptable for them to have a slightly higher MSRV than the other targets.See also #2805 (comment) and linked issues.