Replace tera with rinja#2292
Merged
GuillaumeGomez merged 6 commits intorust-lang:masterfrom Jul 16, 2024
Merged
Conversation
524bb91 to
83153d1
Compare
83153d1 to
425aae0
Compare
425aae0 to
d1db306
Compare
a92b9ce to
3754294
Compare
ef5f330 to
6e7fa52
Compare
6e7fa52 to
b327b35
Compare
64ee87b to
6dfab34
Compare
c4bc7e0 to
ff78a04
Compare
Member
Author
|
Fixed the fix for JS mime types. |
Member
Author
|
CI passed. \o/ |
Member
Author
|
This issue allowed me to uncover a bug in rinja. PR for fix is open here. |
607fbd8 to
bd6386c
Compare
Member
Author
|
Fixed the bug. Should be ready now. |
bd6386c to
2aa2e12
Compare
Member
Author
|
Forgot to add a |
syphar
approved these changes
Jul 16, 2024
Member
syphar
left a comment
There was a problem hiding this comment.
I can't find anything else, so I would propose we go for it.
We probably will find some edge cases in production, but I feel safer with compile time checked templates.
Can you release rinja and change the dependency?
Also you can do any rebasing, if you wanted to do any.
This was referenced Jul 16, 2024
Member
Author
|
Normally it should already be rebased. Gonna make a release today hopefully. |
2aa2e12 to
698f218
Compare
Member
Author
|
Released |
Turbo87
reviewed
Sep 5, 2024
| <li class="pure-menu-item"> | ||
| <a href="https://crates.io/crates/{{ krate.name }}" class="pure-menu-link" title="See {{ krate.name }} in crates.io"> | ||
| {{ "cube" | fas }} crates.io | ||
| {{ "cube"|fas(false, false, "")|safe }} Crates.io |
Member
There was a problem hiding this comment.
@GuillaumeGomez was there a reason for reverting this back to capitalized? (see #2508)
Member
Author
There was a problem hiding this comment.
No, mistake on my end. Gonna send a PR to fix it.
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.