avoid the core_intrinsics feature (for a transition)#557
Closed
RalfJung wants to merge 1 commit intorust-lang:masterfrom
Closed
avoid the core_intrinsics feature (for a transition)#557RalfJung wants to merge 1 commit intorust-lang:masterfrom
RalfJung wants to merge 1 commit intorust-lang:masterfrom
Conversation
14eb0da to
16d366a
Compare
Member
Author
|
Oh no, the rabbit hole is deep... libm also uses core_intrinsics... |
Member
|
maybe its easier to just special case core_intrinsics in rustc instead of renaming |
Member
Author
|
That is an option, but hard-coding a lib feature name in the compiler did not seem great... |
Member
|
🤷 it seems easier than all of this nightmare stuff, and like, I don't think it will change or cause significant trouble to hardcode it, intrinsics are very entangled anyways |
Member
Author
|
You are probably right, I'm just too much of a perfectionist. 🙈 |
Member
Author
|
All right, trying to do this without a rename now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should let us do the transition in rust-lang/rust#118123.