Call cmake via emcmake when building for Emscripten#137
Merged
m-ou-se merged 3 commits intorust-lang:masterfrom May 11, 2022
Merged
Call cmake via emcmake when building for Emscripten#137m-ou-se merged 3 commits intorust-lang:masterfrom
cmake via emcmake when building for Emscripten#137m-ou-se merged 3 commits intorust-lang:masterfrom
Conversation
Member
|
Can this link to documentation on the web? Also if this is to be supported it might be good to add something to CI so it's known when it breaks. |
There is another local variable called "target" -- the one for compilation target platform. This variable is CMake build target. Move it closer to the only place where it's used to avoid shadowing the other "target", which will soon be needed.
Soon these commands are going to become a bit different, make sure they can stay different.
Emscripten toolchain has "emcmake" helper which sets the proper CMAKE_TOOLCHAIN_FILE and other CMake variables that get CMake to produce build files for cross-compiling via Emscripten. There is also "emmake" helper that sets the environment variables for cross-compilation. It should not be necessary for CMake when used with Makefiles and Ninja, but Emscripten recommends it anyway.
Contributor
Author
Done. I've added a link to Emscripten site, explaining the use of
Given that But I am working on some small example to test CMake integration, not only with Emscripten targets. It's a bit tricky to get that tested "nicely".
|
Member
|
Ok, sorry but I've decided that I will no longer maintain this crate and it needs a new maintainer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emscripten toolchain has
emcmakehelper which sets the proper CMAKE_TOOLCHAIN_FILE and other CMake variables that get CMake to produce build files for cross-compiling via Emscripten.There is also
emmakehelper that sets the environment variables for cross-compilation. It should not be necessary for CMake when used with Makefiles and Ninja, but Emscripten recommends it anyway.See #117 and Building Projects.