build: Don't pass inherited PGO flags to GNU compilers#1363
Merged
NobodyXu merged 1 commit intorust-lang:mainfrom Jan 12, 2025
Merged
build: Don't pass inherited PGO flags to GNU compilers#1363NobodyXu merged 1 commit intorust-lang:mainfrom
NobodyXu merged 1 commit intorust-lang:mainfrom
Conversation
madsmtm
approved these changes
Jan 12, 2025
Contributor
madsmtm
left a comment
There was a problem hiding this comment.
Approve of the approach, only concern is code comment (which is non-blocking if we're in a hurry).
Clang and GNU use different PGO libraries, so PGO flags inherited from rustc should not automatically be passed to GNU compilers. Fixes rust-lang#1354
6504074 to
74ba8a1
Compare
Merged
This was referenced Jan 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang and GNU use different PGO libraries, so PGO flags inherited from rustc should not automatically be passed to GNU compilers.
Fixes #1354