[New custom build] Implement platform-specific dependencies by tomaka · Pull Request #735 · rust-lang/cargo

tomaka · 2014-10-21T16:40:49Z

alexcrichton · 2014-10-21T16:48:28Z

src/cargo/core/resolver.rs

This is actually called pretty frequently due to the recursive nature of resolve, and I think this could get away with the more cheap Option<&'a str>, would that be possible?

alexcrichton · 2014-10-21T16:55:06Z

Looks fantastic, thanks so much @tomaka! As mentioned on IRC I think I'll wait to merge this until the RFC gets merged, but hopefully that won't take too long!

tomaka · 2014-10-21T18:01:56Z

Updated

tomaka · 2014-10-21T18:07:48Z

Oops, I forgot to remove the call to rustc_version in cargo_rustc::Context

tomaka · 2014-10-21T18:17:03Z

Updated

alexcrichton · 2014-10-21T22:32:25Z

src/cargo/core/resolver.rs

It's probably ok to omit the ref + clone() here (as well as below)

alexcrichton · 2014-10-21T22:35:51Z

Looks fantastic, thanks @tomaka! I'll hold off on this pending the resolution of rust-lang/rfcs#403.

alexcrichton · 2014-10-28T01:08:36Z

BTW: I added a location in which we'll need to upload this information to the registry, you'll just need to fill it out: https://github.com/rust-lang/cargo/blob/master/src/cargo/ops/registry.rs#L75

tomaka · 2014-10-28T10:56:50Z

BTW: I added a location in which we'll need to upload this information to the registry, you'll just need to fill it out: https://github.com/rust-lang/cargo/blob/master/src/cargo/ops/registry.rs#L75

Done

alexcrichton · 2014-10-28T15:14:38Z

Ah I knew I forgot one other location! https://github.com/rust-lang/cargo/blob/master/src/cargo/sources/registry.rs#L420 (I can fix this up after merging as well, which can hopefully happen today!)

tomaka · 2014-10-28T15:47:54Z

I fixed it too

alexcrichton · 2014-10-28T15:49:14Z

Thanks @tomaka!

alexcrichton · 2014-10-30T23:15:37Z

RFC was approved this afternoon, let's see what bors thinks of this!

alexcrichton reviewed Oct 21, 2014
View reviewed changes

tomaka force-pushed the platform-specific-deps branch from de65c36 to b79c99f Compare October 21, 2014 18:01

tomaka force-pushed the platform-specific-deps branch from b79c99f to b194050 Compare October 21, 2014 18:04

tomaka force-pushed the platform-specific-deps branch from b194050 to 075832e Compare October 21, 2014 18:16

alexcrichton reviewed Oct 21, 2014
View reviewed changes

src/cargo/core/resolver.rs Outdated

Copy link

Member

alexcrichton Oct 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably ok to omit the ref + clone() here (as well as below)

tomaka force-pushed the platform-specific-deps branch 2 times, most recently from 77ebc37 to a3c5b06 Compare October 23, 2014 09:54

tomaka changed the title ~~Implement platform-specific dependencies~~ [New custom build] Implement platform-specific dependencies Oct 23, 2014

tomaka mentioned this pull request Oct 27, 2014

Remove necessity to use a makefile rust-windowing/glutin#46

Closed

tomaka force-pushed the platform-specific-deps branch from a3c5b06 to 1549b5c Compare October 27, 2014 08:29

tomaka mentioned this pull request Oct 27, 2014

[New custom build] Implement the new custom build command #763

Closed

tomaka force-pushed the platform-specific-deps branch from 1549b5c to 58cc1e0 Compare October 28, 2014 08:24

tomaka added 2 commits October 28, 2014 09:29

Implement platform-specific dependencies

8495548

Fill ops::registry::transmit with the right value

f16291d

tomaka force-pushed the platform-specific-deps branch from 58cc1e0 to f16291d Compare October 28, 2014 08:31

Fix sources::registry::parse_registry_dependency

63a3410

Conversation

tomaka commented Oct 21, 2014

Uh oh!

alexcrichton Oct 21, 2014

Choose a reason for hiding this comment

Uh oh!

alexcrichton commented Oct 21, 2014

Uh oh!

tomaka commented Oct 21, 2014

Uh oh!

tomaka commented Oct 21, 2014

Uh oh!

tomaka commented Oct 21, 2014

Uh oh!

alexcrichton Oct 21, 2014

Choose a reason for hiding this comment

Uh oh!

alexcrichton commented Oct 21, 2014

Uh oh!

alexcrichton commented Oct 28, 2014

Uh oh!

tomaka commented Oct 28, 2014

Uh oh!

alexcrichton commented Oct 28, 2014

Uh oh!

tomaka commented Oct 28, 2014

Uh oh!

alexcrichton commented Oct 28, 2014

Uh oh!

alexcrichton commented Oct 30, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants