feat(publish): idempotent workspace publish#16012
Draft
weihanglo wants to merge 3 commits intorust-lang:masterfrom
Draft
feat(publish): idempotent workspace publish#16012weihanglo wants to merge 3 commits intorust-lang:masterfrom
weihanglo wants to merge 3 commits intorust-lang:masterfrom
Conversation
Collaborator
|
Why only for the workspaces? Doesn't it make sense to do it for the non-workspace publish too? |
Member
Author
See #13397 (comment) |
e3d7ab5 to
3f1b4fc
Compare
3f1b4fc to
45d9430
Compare
45d9430 to
17d5186
Compare
17d5186 to
2c5808e
Compare
Before this, `cargo publish --workspace` would fail if any member packages were already published. After this, it skips already published packages and continues with the rest. To make sure the local package is really published, we verify the checksum of the newly packed `.crate` tarball against the checksum from the registry index. This helps catch cases where the package contents changed but the version wasn’t bumped, which would otherwise be treated as already published.
2c5808e to
f85dbd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Before this,
cargo publish --workspacewould failif any member packages were already published.
After this, it skips already published packages
and continues with the rest.
To make sure the local package is really published,
we verify the checksum of the newly packed
.cratetarballagainst the checksum from the registry index.
This helps catch cases where the package contents changed
but the version wasn’t bumped,
which would otherwise be treated as already published.
fixes #13397
How to test and review this PR?
Need discussions, FCP, and maybe an unstable flag.
Some other design questions:
--workspacepublish?--verifyfor already published packages.