[Beta] backport "Be resilient to most IO error and filesystem loop while walking dirs"#10286
Merged
bors merged 1 commit intorust-lang:rust-1.59.0from Jan 12, 2022
Merged
Conversation
…alexcrichton Be resilient to most IO error and filesystem loop while walking dirs Let `PathSource::walk` be resilient to most IO errors and filesystem loop. This PR also - Add a test validating the resilience against filesystem loop to prevent regression. - Emit warning when filesystem loop found while walking the filesystem. This is the only way I can think of now to solve rust-lang#9528 Fixes rust-lang#10213.
|
r? @ehuss (rust-highfive has picked a reviewer for you, use r? to override) |
|
Member
Author
|
I took other backport PRs as references, but not sure if I did it right. |
Member
|
@bors: r+ Nah looks good! It's basically just a cherry-pick and a PR against the correct branch which looks to all be in order here |
Contributor
|
📌 Commit 7267b05 has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beta backport of #10214.