-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Open
Labels
C-tracking-issueCategory: A tracking issue for something unstable.Category: A tracking issue for something unstable.S-acceptedStatus: Issue or feature is accepted, and has a team member available to help mentor or reviewStatus: Issue or feature is accepted, and has a team member available to help mentor or reviewZ-out-dirNightly: --out-dirNightly: --out-dir
Description
Note: this was renamed from --out-dir to --artifact-dir in #13809
Original issue: #4875
Implementation PR: #5203
Documentation: https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#artifact-dir
Issues:
Z-out-dir
Summary
Adds --artifact-dir=PATH flag to cargo build to specify a directory to place final artifacts.
Tasks:
- cargo build --out-dir #5203
- Rename --out-dir to --artifact-dir #13809
- Remove
--out-dir - Switch
--artifact-dirto being the directory we uplift directly into with a fallback to the current location (done across all commands includingcargo package) - Evaluate recording requested uplifts and performing them at the end
- Evaluate only creating
examples/if needed (helps if we know a priori what is uplifted) - Detect conflicts in uplifts due to platform-tuple not being included
- (design needed) explore templating of artifact-dir
- Rework to better match Redefine
CARGO_TARGET_DIRto be only an artifacts directory #14125 (comment)
Unresolved questions
- Multi-target builds (
--target <one> --target <two>) - MSVC examples cannot be exported with out-dir #7493
- Is
--out-dirjustified or can we find another way of accomplishing it? #6100 — concern about similarity with--target-dir, proliferation of flags - Duplicate artifact tracking issue. #6313 — concern about name collisions in workspaces or with examples
- What exactly is the use case for this? In what scenario would it be used where you don't already have an outer build system or script that can copy the files into the correct location?
- Confusion with rustc's
--out-dir(Rename --out-dir to --artifact-dir #13809) - Discrepancy or confusion with
build.rssOUT_DIR(depends on ifbuild.rsis generating intermediate or final artifacts) (Rename --out-dir to --artifact-dir #13809)
Future possibilities
- Deprecate
--target-dir, hiding it from the CLI help
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C-tracking-issueCategory: A tracking issue for something unstable.Category: A tracking issue for something unstable.S-acceptedStatus: Issue or feature is accepted, and has a team member available to help mentor or reviewStatus: Issue or feature is accepted, and has a team member available to help mentor or reviewZ-out-dirNightly: --out-dirNightly: --out-dir
Type
Projects
Status
Unstable, no backers