Skip to content

Regression in resolver performance #5130

@alexcrichton

Description

@alexcrichton

Noticed at #5044 (comment) it looks like the resolver loop was tweaked in #5000 to unconditionally clone the Context before each invocation of activate instead of only if has_another is true later on, some more info at #5044 (comment).

The line in question looks to be

context_backup: Context::clone(&cx),
.

@Eh2406 says they're gonna look into this, so just wanted to open a tracking issue for it!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions