Closed
Conversation
kenden
reviewed
Sep 26, 2023
kenden
left a comment
There was a problem hiding this comment.
In my humble opinion, this is a bit harder to read with this change.
Maybe the problematic phrase in bug #3561 could be simply changed to:
- Then we can create a vector to hold that enum and so, ultimately, holds different types.
+ Then we can create a vector to hold that enum. So, in effect, that vector will hold different types.
Changes are per suggestion
kenden
reviewed
Sep 30, 2023
Extra spaces removed
Author
|
If it serves the purpose, then would request to merge it. :) |
Contributor
|
Thank you for the PR! After reading the context, I decided #3874 was a better fix here, though, so I am closing this in favor of that. 👍🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3561