Added FuturesUnordered chapter#96
Closed
capnhawkbill wants to merge 2 commits intorust-lang:masterfrom
Closed
Conversation
tmandry
reviewed
Jul 16, 2020
Comment on lines
+9
to
+12
| Because `FuturesUnordered` implements the `Stream` trait using `.next()` | ||
| on it will return a `Future` which returns the return value from one of | ||
| the futures inside of an `Option`. | ||
| It will return `None` when all futures are completed. |
Member
There was a problem hiding this comment.
I think this could be even more concise, something like
Suggested change
| Because `FuturesUnordered` implements the `Stream` trait using `.next()` | |
| on it will return a `Future` which returns the return value from one of | |
| the futures inside of an `Option`. | |
| It will return `None` when all futures are completed. | |
| `FuturesUnordered` implements a `Stream` trait over the | |
| output of the futures in any order. |
The example implies how to use that Stream (and hopefully we have dedicated docs for that too).
Author
There was a problem hiding this comment.
Yes I agree this is a lot clearer
Member
|
Triage: closing due to age and conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the chapter about FuturesUnordered, it's a bit short but I think it gets the message across