-
Notifications
You must be signed in to change notification settings - Fork 93
Closed
Description
It seems that 1.4.0 is making assumptions about items in the current space, which is a breaking change, and fails to build on projects who were dependent on any 1 version, such as previously 1.3.2.
I discovered this error because projects using new projects created using the soroban-sdk crate started pulling in arbitrary and derive_arbitrary 1.4.0 and see build errors.
$ git clone https://github.com/stellar/rs-soroban-sdk
$ git checkout fc32690edd223fd01054c625d9c6dca01bd99e67 # main at today's date
$ cd rs-soroban-sdk
$ cargo update arbitrary --precise 1.4.0
$ cargo test
Included in the output are the following build errors:
error[E0107]: type alias takes 1 generic argument but 2 generic arguments were supplied
--> /Users/leighmcculloch/.cargo/registry/src/index.crates.io-6f17d22bba15001f/stellar-xdr-22.0.0-rc.1.1/src/curr/generated.rs:935:42
|
935 | #[cfg_attr(feature = "arbitrary", derive(Arbitrary))]
| ^^^^^^^^^ expected 1 generic argument
|
note: type alias defined here, with 1 generic parameter: `T`
--> /Users/leighmcculloch/.cargo/registry/src/index.crates.io-6f17d22bba15001f/stellar-xdr-22.0.0-rc.1.1/src/curr/generated.rs:226:6
|
226 | type Result<T> = core::result::Result<T, Error>;
| ^^^^^^ -
= note: this error originates in the derive macro `Arbitrary` (in Nightly builds, run with -Z macro-backtrace for more info)
error[E0053]: method `try_size_hint` has an incompatible type for trait
--> /Users/leighmcculloch/.cargo/registry/src/index.crates.io-6f17d22bba15001f/stellar-xdr-22.0.0-rc.1.1/src/curr/generated.rs:935:42
|
935 | #[cfg_attr(feature = "arbitrary", derive(Arbitrary))]
| ^^^^^^^^^ expected `MaxRecursionReached`, found `generated::Error`
|
= note: expected signature `fn(_) -> std::result::Result<_, MaxRecursionReached>`
found signature `fn(_) -> std::result::Result<_, generated::Error>`
= note: this error originates in the derive macro `Arbitrary` (in Nightly builds, run with -Z macro-backtrace for more info)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels