update libsecp, remove endomorphism feature flag and release 0.20.0#257
Merged
apoelstra merged 6 commits intorust-bitcoin:masterfrom Jan 3, 2021
Merged
update libsecp, remove endomorphism feature flag and release 0.20.0#257apoelstra merged 6 commits intorust-bitcoin:masterfrom
apoelstra merged 6 commits intorust-bitcoin:masterfrom
Conversation
83663db to
833b176
Compare
Contributor
|
This looks like an important and trivial bugfix which may get merged before this release: #266 |
Member
|
Can you also remove the endianess checks? they aren't needed anymore bitcoin-core/secp256k1#787 |
elichai
previously approved these changes
Dec 29, 2020
Member
elichai
left a comment
There was a problem hiding this comment.
tACK
I tested rm -rf /depend/secp256k1 and ./vendor-libsecp.sh depend 0_4_0 master to make sure the results match,
585d43d to
8511ec0
Compare
8511ec0 to
c4d2fef
Compare
sgeisler
approved these changes
Jan 3, 2021
elichai
approved these changes
Jan 3, 2021
Member
elichai
left a comment
There was a problem hiding this comment.
tACK, ran the vendoring script on my machine and it produced the same result
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.